Skip to content

Upgrading yarn packages#3725

Merged
adleong merged 1 commit intomasterfrom
cscott/upgrade-yarn
Nov 14, 2019
Merged

Upgrading yarn packages#3725
adleong merged 1 commit intomasterfrom
cscott/upgrade-yarn

Conversation

@scottcarol
Copy link
Copy Markdown
Contributor

This PR upgrades yarn dependencies, including bumping the es-abstract package (a sub-dependency of some of our packages) from 1.14.0 to 1.16.0 which should resolve the 404 from yarn and enable our branch to pass CI. The only file change is yarn.lock. The change was made by running yarn upgrade from /web/app.

To test, checkout this branch, run bin/web setup & bin/web dev, then test localhost:7777 to ensure the dashboard is running normally.

@siggy siggy requested review from alpeb and siggy November 14, 2019 18:22
@siggy siggy assigned scottcarol and unassigned siggy and alpeb Nov 14, 2019
Copy link
Copy Markdown
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@adleong adleong merged commit d79494d into master Nov 14, 2019
@scottcarol scottcarol deleted the cscott/upgrade-yarn branch November 14, 2019 18:52
Copy link
Copy Markdown
Member

@siggy siggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my machine 👍 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants