Skip to content

Fix integration test#3266

Merged
alpeb merged 1 commit intomasterfrom
alpeb/int-test-namespace-length
Aug 15, 2019
Merged

Fix integration test#3266
alpeb merged 1 commit intomasterfrom
alpeb/int-test-namespace-length

Conversation

@alpeb
Copy link
Member

@alpeb alpeb commented Aug 15, 2019

Followup to #3194

The namespace was too long for l5d-bot:

    inject_test.go:117: failed to create
    l5d-integration-auto-git-9688d9ba-inject-namespace-override-test
    namespace: Namespace
    "l5d-integration-auto-git-9688d9ba-inject-namespace-override-test"
    is invalid: metadata.name: Invalid value:
    "l5d-integration-auto-git-9688d9ba-inject-namespace-override-test":
    must be no more than 63 characters

Signed-off-by: Alejandro Pedraza [email protected]

Followup to #3194

The namespace was too long for l5d-bot:

```
    inject_test.go:117: failed to create
    l5d-integration-auto-git-9688d9ba-inject-namespace-override-test
    namespace: Namespace
    "l5d-integration-auto-git-9688d9ba-inject-namespace-override-test"
    is invalid: metadata.name: Invalid value:
    "l5d-integration-auto-git-9688d9ba-inject-namespace-override-test":
    must be no more than 63 characters
```

Signed-off-by: Alejandro Pedraza <[email protected]>
@alpeb alpeb self-assigned this Aug 15, 2019
@l5d-bot
Copy link
Collaborator

l5d-bot commented Aug 15, 2019

@alpeb alpeb requested a review from Pothulapati August 15, 2019 12:21
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! :p
Good to go!

@cpretzer
Copy link
Contributor

Good fix! 👍

@alpeb alpeb merged commit fd5fc07 into master Aug 15, 2019
@alpeb alpeb deleted the alpeb/int-test-namespace-length branch August 15, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants