Added labels to webhook configurations in charts/#2853
Merged
alpeb merged 1 commit intolinkerd:masterfrom May 28, 2019
Pothulapati:master
Merged
Added labels to webhook configurations in charts/#2853alpeb merged 1 commit intolinkerd:masterfrom Pothulapati:master
alpeb merged 1 commit intolinkerd:masterfrom
Pothulapati:master
Conversation
Signed-off-by: Tarun Pothulapati <[email protected]>
alpeb
approved these changes
May 28, 2019
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
Looks great, thanks Tarun for having followed up on your previous PR! 🚢
Contributor
|
Oppss.. I missed this by a minute. Not a big deal, but the next time we are here, we should use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2602
Added Controller component labels for webhook configurations.
Signed-off-by: Tarun Pothulapati [email protected]