Modify upgrade integration test to upgrade stable#2835
Conversation
|
Integration test results for 007eba6: fail 😕 |
In #2679 we introduced an upgrade integration test. At the time we only supported upgrading from a recent edge. Since that PR, a stable build was released supporting upgrade. Modify the upgrade integration test to upgrade from the latest stable rather than latest edge. This fulfills the original intent of #2669. Also add some known k8s event warnings. Signed-off-by: Andrew Seigner <[email protected]>
siggy
force-pushed
the
siggy/test-stable-upgrade
branch
from
007eba6 to
0e19d9e
Compare
|
Integration test results for 0e19d9e: success 🎉 |
dadjeibaah
left a comment
dadjeibaah
left a comment
There was a problem hiding this comment.
This PR LGTM! Thanks for updating this. Just curious, are there cases where w'd like to test for upgrading edge -> stable or vice versa?
|
@dadjeibaah I think it's ok to limit the integration test to just test stable -> stable for now, to cover typical user's production upgrade scenario. There may be some values in covering the edge -> stable scenario (not so sure about stable -> edge), but we will likely run into more test failures related to cluster-scoped resources; i.e. depending on if we run stable -> stable or edge -> stable upgrade first, the test failures might be different. |
|
@ihcsim that makes sense. Testing for those other use cases are more aligned with edge testing and its not the typical production use case. |
4 participants
In #2679 we introduced an upgrade integration test. At the time we only
supported upgrading from a recent edge. Since that PR, a stable build
was released supporting upgrade.
Modify the upgrade integration test to upgrade from the latest stable
rather than latest edge. This fulfills the original intent of #2669.
Also add some known k8s event warnings.
Signed-off-by: Andrew Seigner [email protected]