Added controller component labels to webhook configurations#2820
Merged
alpeb merged 1 commit intolinkerd:masterfrom May 15, 2019
Pothulapati:labels
Merged
Added controller component labels to webhook configurations#2820alpeb merged 1 commit intolinkerd:masterfrom Pothulapati:labels
alpeb merged 1 commit intolinkerd:masterfrom
Pothulapati:labels
Conversation
Signed-off-by: Tarun Pothulapati <[email protected]>
alpeb
approved these changes
May 14, 2019
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
Thanks @Pothulapati , this looks good to me 👍
After this merges, please keep an eye open for #2806, which will be moving these resources into /chart/templates
Contributor
Author
|
Ah Right! I will keep an eye an eye out on the PR, and submit a PR regarding labels, once it merges. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2602
This adds the
linkerd.io/control-plane-componentlabel to the proxy-injector and sp-validator webhook Congurations.The following query would work after this
kubectl get MutatingWebhookConfigurations,ValidatingWebhookConfigurations -l 'linkerd.io/control-plane-component in (proxy-injector,sp-validator)'Signed-off-by: Tarun Pothulapati [email protected]