Conversation
|
Integration test results for aef878b: fail 😕 |
ihcsim
left a comment
ihcsim
left a comment
There was a problem hiding this comment.
LGTM 👍
Question: Is there a plan to extend the unit test cases in TestConfigExists() to include checks for cluster role, cluster role bindings and service accounts?
@ihcsim good point, i've updated the unit tests to include a successful check of all the new resources. |
Add support for `linkerd check config`. Validates the existence of the Linkerd Namespace, ClusterRoles, ClusterRoleBindings, ServiceAccounts, and CustomResourceDefitions. Part of #2337 Signed-off-by: Andrew Seigner <[email protected]>
Signed-off-by: Andrew Seigner <[email protected]>
siggy
force-pushed
the
siggy/check-stages
branch
from
ed56951 to
04ecc05
Compare
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
Looks good to me, modulo my comment below.
Nice tests refactors 👍
cli/cmd/check.go
Outdated
| flags := pflag.NewFlagSet("check", pflag.ExitOnError) | ||
|
|
||
| flags.StringVar(&options.versionOverride, "expected-version", options.versionOverride, "Overrides the version used when checking if Linkerd is running the latest version (mostly for testing)") | ||
| flags.StringVarP(&options.namespace, "namespace", "n", options.namespace, "Namespace to use for --proxy checks (default: all namespaces)") |
There was a problem hiding this comment.
Given this is to be used with --proxy, it should belong into nonConfigFlagSet() instead
Signed-off-by: Andrew Seigner <[email protected]>
Signed-off-by: Andrew Seigner <[email protected]>
Signed-off-by: Andrew Seigner <[email protected]>
|
Integration test results for b2e08fa: success 🎉 |
|
Integration test results for 3cb0cfa: fail 😕 |
4 participants
Add support for
linkerd check config. Validates the existence of theLinkerd Namespace, ClusterRoles, ClusterRoleBindings, ServiceAccounts,
and CustomResourceDefitions.
Part of #2337
Signed-off-by: Andrew Seigner [email protected]