Fix linkerd check --proxy with default ns param#2754
Merged
Conversation
The `linkerd check --proxy` command checks for proxies in all namespaces, if the `--namespace` flag is not set. PR #2747 modified the behavior of `KubernetesAPI.NamespaceExists`. Previously it would succeed if given an emptry string for a namespace. Now it fails with a `resource name may not be empty` error (for k8s server `v1.10.11`), or a not found error (for our fake test client). Modify the data plane proxy namespace check to return success if the namespace is not set. Signed-off-by: Andrew Seigner <[email protected]> fix lint Signed-off-by: Andrew Seigner <[email protected]>
siggy
force-pushed
the
siggy/fix-data-plane-default-ns
branch
from
f31a720 to
8c0945a
Compare
Collaborator
|
Integration test results for 8c0945a: fail 😕 |
Member
|
Lookgs good to me 👍 |
Member
|
Integration tests did succeed in my local btw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
linkerd check --proxycommand checks for proxies in allnamespaces, if the
--namespaceflag is not set. PR #2747 modified thebehavior of
KubernetesAPI.NamespaceExists. Previously it would succeedif given an emptry string for a namespace. Now it fails with a
resource name may not be emptyerror (for k8s serverv1.10.11), or anot found error (for our fake test client).
Modify the data plane proxy namespace check to return success if the
namespace is not set.
Signed-off-by: Andrew Seigner [email protected]