Conversation
This change introduces some unit tests on individual methods in the upgrade code path, along with some minor cleanup. Part of #2637 Signed-off-by: Andrew Seigner <[email protected]>
|
Integration test results for 9ba396d: success 🎉 |
ihcsim
left a comment
ihcsim
left a comment
There was a problem hiding this comment.
LGTM. Just some minor comments and TIOLI.
| } | ||
| } | ||
|
|
||
| // TODO: are `installValues.Configs` and `configs` redundant? |
There was a problem hiding this comment.
I think installValues.Configs is used in the chart/templates/config.yaml helm chart template. Essentially, it's the JSON of configs.
There was a problem hiding this comment.
I think my question is more around: If installValues.Configs and configs are just different representations of the same data, can we just keep one copy of that data around, and generate one version from the other on-demand? Any time we have multiple copies of the same data, I get concerned about which version is the source of truth, and what happens if they are not in sync.
siggy
force-pushed
the
siggy/update-upgrade-unit
branch
from
9003ace to
9ba396d
Compare
|
Integration test results for 9ba396d: success 🎉 |
Signed-off-by: Andrew Seigner <[email protected]>
|
Integration test results for 3ca1c3c: success 🎉 |
3 participants
This change introduces some unit tests on individual methods in the
upgrade code path, along with some minor cleanup.
Part of #2637
Signed-off-by: Andrew Seigner [email protected]