Conversation
siggy
force-pushed
the
siggy/upgrade-unit
branch
2 times, most recently
from
41e7a36 to
b7deb41
Compare
siggy
force-pushed
the
siggy/upgrade-unit
branch
from
b7deb41 to
1efead7
Compare
This change introduces a basic unit test for the `linkerd upgrade` command. Given a mock k8s client with linkerd-config and linkerd-identity-issuer objects, it validates the rendered yaml output against an expected file. To enable this testing, most of the logic in the top-level upgrade command has been moved down into a `validateAndBuild` method. TODO: - test individual functions around mutating options, flags, configs, and values - enable reading the install information from a manifest rather than k8s Part of #2637 Signed-off-by: Andrew Seigner <[email protected]>
siggy
force-pushed
the
siggy/upgrade-unit
branch
from
1efead7 to
f8b8028
Compare
Collaborator
|
Integration test results for f8b8028: success 🎉 |
klingerf
approved these changes
Apr 5, 2019
Contributor
klingerf
left a comment
klingerf
left a comment
There was a problem hiding this comment.
⭐️ 🎉 Hooray for more tests!
KatherineMelnyk
pushed a commit
to KatherineMelnyk/linkerd2
that referenced
this pull request
Apr 5, 2019
This change introduces a basic unit test for the `linkerd upgrade` command. Given a mock k8s client with linkerd-config and linkerd-identity-issuer objects, it validates the rendered yaml output against an expected file. To enable this testing, most of the logic in the top-level upgrade command has been moved down into a `validateAndBuild` method. TODO: - test individual functions around mutating options, flags, configs, and values - enable reading the install information from a manifest rather than k8s Part of linkerd#2637 Signed-off-by: Andrew Seigner <[email protected]> Signed-off-by: [email protected] <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a basic unit test for the
linkerd upgradecommand. Given a mock k8s client with linkerd-config and
linkerd-identity-issuer objects, it validates the rendered yaml output
against an expected file.
To enable this testing, most of the logic in the top-level upgrade
command has been moved down into a
validateAndBuildmethod.TODO:
values
Part of #2637
Signed-off-by: Andrew Seigner [email protected]