Merged
Conversation
klingerf
approved these changes
Feb 2, 2018
Contributor
klingerf
left a comment
klingerf
left a comment
There was a problem hiding this comment.
⭐️ Thanks for adding, and for fixing the existing races.
briansmith
reviewed
Feb 2, 2018
controller/api/public/client_test.go
Outdated
| } | ||
| }) | ||
| } | ||
| // func TestNewInternalClient(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Why is this code commented out?
Member
Author
There was a problem hiding this comment.
(sorry this is wip, trying to get it to pass ci)
We previously did not have race detection enabled because our tests would fail. Following #249, this is no longer the case. Enable race detection in ci and build instructions. This change also fixes client_test.go attempting to allocate a 2GB buffer due to bad test input. Fixes #173 Signed-off-by: Andrew Seigner <[email protected]>
siggy
commented
Feb 2, 2018
| mockTransport.responseToReturn = &http.Response{ | ||
| StatusCode: 500, | ||
| Body: ioutil.NopCloser(strings.NewReader("body")), | ||
| Body: ioutil.NopCloser(bufferedReader(t, &pb.Empty{})), |
Member
Author
There was a problem hiding this comment.
2GB allocation in deserializePayloadFromReader()!
int(binary.LittleEndian.Uint32([]byte("body"))) == 2036625250
alpeb
added a commit
that referenced
this pull request
Aug 15, 2019
Fixes #259 Signed-off-by: Alejandro Pedraza <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously did not have race detection enabled because our tests
would fail. Following #249, this is no longer the case.
Enable race detection in ci and build instructions.
Fixes #173