install: Introduce the Identity controller#2526
Merged
Conversation
olix0r
commented
Mar 19, 2019
#2521 introduces an "Identity" controller, but there is no way to include it in linkerd installation. This change alters the `install` flow as follows: - An Identity service is _always_ installed; - Issuer credentials may be specified via the CLI; - If no Issuer credentials are provided, they are generated each time `install` is called. - Proxies are NOT configured to use the identity service. - It's possible to override the credential generation logic---especially for tests---via install options that can be configured via the CLI.
olix0r
force-pushed
the
ver/identity-install
branch
from
b409040 to
18368cc
Compare
klingerf
reviewed
Mar 19, 2019
Contributor
klingerf
left a comment
klingerf
left a comment
There was a problem hiding this comment.
Looking good. I had constructed most of my comments based on the previous diff, so a few of these may be outdated. Sorry about that. Will give it a re-review once you've addressed the rest.
olix0r
commented
Mar 19, 2019
alpeb
reviewed
Mar 19, 2019
klingerf
approved these changes
Mar 19, 2019
Contributor
klingerf
left a comment
klingerf
left a comment
There was a problem hiding this comment.
⭐️ Great, updates look good to me.
We shouldn't do this as part of this branch, but I'm starting a small list of tasks that we should complete in order to treat the new identity pod as a fully fledged member of the control plane, as follows:
- Update
linkerd checkto start verifying that the new pod is up and running - Update the web UI to display the health of the pod in the table on the Service Mesh page
- Update the install integration test to validate that the identity pod is running and has not been restarted
There are probably a few more places it needs to be added as well.
ihcsim
approved these changes
Mar 19, 2019
Contributor
ihcsim
left a comment
ihcsim
left a comment
There was a problem hiding this comment.
LGTM. Just a few questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2521 introduces an "Identity" controller, but there is no way to include it in linkerd installation.
This change alters the
installflow as follows:installis called.