Conversation
- align top two tables in the service mesh page - "All Deployments" -> "Deployments" - reorder latency p50, p95, p99 - "Current success" -> "Success rate" Signed-off-by: Risha Mars <[email protected]>
| .service-mesh-table { | ||
| margin-top: 18px; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is a big improvement. I wonder if we want to do the same for .incomplete-mesh-message, .complete-mesh-message. We could add a 32px top margin to those classes to line them up with the header of the Data Plane table. This is how it looks now:
And with 32px padding:
What do you think?
There was a problem hiding this comment.
yeah, that looks better to me! will do!
| <div className="current-latency"> | ||
| { | ||
| _.map(["P99", "P95", "P50"], latency => { | ||
| _.map(["P50", "P95", "P99"], latency => { |
There was a problem hiding this comment.
As part of this change can we also reorder the latency columns in TabbedMetricsTable:
There was a problem hiding this comment.
oh yeah! forgot about those, thanks!
…csTable Signed-off-by: Risha Mars <[email protected]>
siggy
left a comment
siggy
left a comment
There was a problem hiding this comment.
lgtm modulo kevin's feedback.
something for this branch or a subsequent ui fixup, the Components number looks a bit out of place. perhaps the value should be right-justified, or, something else?
|
whoa good catch, those are supposed to be right aligned. |
Signed-off-by: Risha Mars <[email protected]>
rmars
force-pushed
the
rmars/ui-small-fixes
branch
from
04389c8 to
bceeb8a
Compare
klingerf
left a comment
klingerf
left a comment
There was a problem hiding this comment.
⭐️ Great! Thanks for making those updates.
* README update to 2018 (#233) Signed-off-by: Andrew Seigner <[email protected]> * Prepare for v0.2.0 release (#248) * prepare for v0.2.0 release Signed-off-by: Dennis Adjei-Baah <[email protected]> * Use dots reporter instead of nyan reporter in CI (#238) Signed-off-by: Risha Mars <[email protected]> * Various small UI tweaks (#234) * Various small UI naming tweaks - align top two tables in the service mesh page - "All Deployments" -> "Deployments" - reorder latency p50, p95, p99 - "Current success" -> "Success rate" * Add margin to incomplete mesh message, reorder latency in TabbedMetricsTable * Right align numbers in service mesh page
3 participants
Signed-off-by: Risha Mars [email protected]