Conversation
This replaces a couple of the MaterialUI icons introduced in #1776 with their original counterparts in Font Awesome, but wrapped in a MaterialUI `Icon` tag. Also fix Linkerd logo padding in sidebar. Part of #1781. Signed-off-by: Andrew Seigner <[email protected]>
|
@rmars Per your comment in #1781 (comment), I browsed through the MaterialUI and Font Awesome icons, and couldn't find better fits than what we had before the MaterialUI switch, so I re-added the Font Awesome icons we had for Tap and Top. The Tap microscope now matches the links on the Tap page. For Service Mesh, this was the best I could find, which I don't think is as good as the existing Cloud icon: |
rmars
left a comment
rmars
left a comment
There was a problem hiding this comment.
sweet! thanks for doing this. it's great to see tap as the same icon in both places.
I noticed that the material icons are slightly smaller than the font awesome icons. we should probably fix that disparity, otherwise it'll look slightly off:
Signed-off-by: Andrew Seigner <[email protected]>
|
@rmars modified the two font awesome icons and one material icon to be the same width as most of the others. the material icons vary slightly by height and width, so the resources icon is still a bit smaller, and the cloud icon has less height. let me know what you think... before
after
|
web/app/js/components/Navigation.jsx
Outdated
| paddingRight: `${contentPadding}px`, | ||
| }, | ||
| shrinkIcon: { | ||
| fontSize: "20px", |
There was a problem hiding this comment.
one nit: can we reduce this ever so slightly, to 18px?
There was a problem hiding this comment.
size updated, also bumped the padding to make the icons align through their centers:
Signed-off-by: Andrew Seigner <[email protected]>
2 participants
This replaces a couple of the MaterialUI icons introduced in #1776 with
their original counterparts in Font Awesome, but wrapped in a MaterialUI
Icontag. Also fix Linkerd logo padding in sidebar.Part of #1781.
Signed-off-by: Andrew Seigner [email protected]