Conversation
Also make main content independently scrollable. Part of #1781 Signed-off-by: Andrew Seigner <[email protected]>
3 tasks
rmars
approved these changes
Oct 30, 2018
rmars
left a comment
rmars
left a comment
There was a problem hiding this comment.
🌟 😻 📖 this is great and I like it a lot! thanks for all your work on this!
One thing I noticed was that the left padding of the content decreases a lot when the menu bar is closed. It's not super noticeable, but it's different from the padding on the right hand side, so I feel like we should have that padding consistent.
Spacing when open:
Spacing when closed:
also define all styles in terms of `theme.spacing.unit` Signed-off-by: Andrew Seigner <[email protected]>
Member
Author
|
@rmars good catch! this fix was also a good excuse to define all styles terms of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make main content independently scrollable.
Part of #1781
Signed-off-by: Andrew Seigner [email protected]