Skip to content

Do some small alignment tweaks, fix Firefox rendering#1809

Merged
rmars merged 5 commits intomasterfrom
rmars/align-icons
Oct 25, 2018
Merged

Do some small alignment tweaks, fix Firefox rendering#1809
rmars merged 5 commits intomasterfrom
rmars/align-icons

Conversation

@rmars
Copy link

@rmars rmars commented Oct 24, 2018

This branch:

  • adds a "meshed" badge to the namespace overview page instead of a green checkmark
  • fixes aforementioned meshed indicator not showing up in firefox
  • vertically centers the ( ! ) icons in the metrics tables
  • vertically centers the dots in the metrics tables

Before

screen shot 2018-10-24 at 5 15 14 pm

After

screen shot 2018-10-24 at 5 14 46 pm

Fixes #1805

@rmars rmars added the area/web label Oct 24, 2018
@rmars rmars self-assigned this Oct 24, 2018
@rmars rmars requested review from klingerf and siggy October 24, 2018 23:53
@rmars rmars force-pushed the rmars/align-icons branch from 6b2fcaf to b0cf077 Compare October 25, 2018 00:14
@rmars rmars changed the base branch from rmars/colours to master October 25, 2018 00:14
Copy link
Contributor

@klingerf klingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️ Looks good, nice fixes!

Copy link
Member

@siggy siggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@rmars rmars merged commit 148d7bc into master Oct 25, 2018
@rmars rmars deleted the rmars/align-icons branch October 25, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align and resize material ui check icon in Overview page, fix for Firefox

3 participants