Add Grafana dashboard for Authorities#1772
Merged
rmars merged 2 commits intolinkerd:masterfrom Oct 18, 2018
alpeb:grafana_authorities
Merged
Add Grafana dashboard for Authorities#1772rmars merged 2 commits intolinkerd:masterfrom alpeb:grafana_authorities
rmars merged 2 commits intolinkerd:masterfrom
alpeb:grafana_authorities
Conversation
Proposal for #1225 Signed-off-by: Alejandro Pedraza <[email protected]>
Contributor
|
Awesome! |
klingerf
reviewed
Oct 17, 2018
Contributor
klingerf
left a comment
klingerf
left a comment
There was a problem hiding this comment.
@alpeb Thank you for putting this together! I had a few comments about how we display inbound pods and deployments, but the dashboard setup overall looks great to me. Let me know if any of my comments below don't make sense. Exporting dashboards to JSON can be finicky, unfortunately.
Modified Inbound by Deployment and Inbound by Pod graphs according to klingerf's feedback. Removed template variables values. Signed-off-by: Alejandro Pedraza <[email protected]>
Member
Author
|
Thank you very much @klingerf for your detailed review :-) |
rmars
approved these changes
Oct 18, 2018
rmars
added a commit
that referenced
this pull request
Oct 24, 2018
This branch includes some small appearance tweaks for tables in the app. - Removes the restrictions on the MetricsTables for Authorities Grafana links (Authorities Grafana dashboards were added in #1772) - Fixes the tables overflowing their containers on the Overview page - Allows tables to be denser, allowing for more data on screen - Fixes the colour of the meshed status bar in the ServiceMesh page - Rixes the ErrorModal icon alignment and colour - Small appearance tweaks to the things in the table e.g. icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for #1225
Signed-off-by: Alejandro Pedraza [email protected]