Conversation
Signed-off-by: Kevin Lingerfelt <[email protected]>
dadjeibaah
approved these changes
Sep 14, 2018
Contributor
dadjeibaah
left a comment
dadjeibaah
left a comment
There was a problem hiding this comment.
Changes look great! Thanks for adding this! 📦
rmars
approved these changes
Sep 14, 2018
| title: "Tap", | ||
| key: "tap", | ||
| className: "numeric", | ||
| width: topMetricColWidth, |
There was a problem hiding this comment.
how do you feel about 30px here? The column spacing feels a little wide.
| let toNamespace = ""; | ||
| let toResource = ""; | ||
|
|
||
| if (_.has(d.destinationLabels, resourceType)) { |
There was a problem hiding this comment.
do we care about doing the same fallback to pod here as we do for the sourceLabels? Or is it less important because a tap can be done without the to resources?
Contributor
Author
There was a problem hiding this comment.
Hmm, that's a good point -- I'll the fallback to pods for consistency.
Signed-off-by: Kevin Lingerfelt <[email protected]>
zachalbert
added a commit
to zachalbert/linkerd2
that referenced
this pull request
Sep 15, 2018
* master: Move more info from the tap table into the expanded row (linkerd#1641) `linkerd check` sends params on version check (linkerd#1642) Bikeshed the tap and top icons (linkerd#1637) Add link to tap each row in top table (linkerd#1643) Bump default check retry time to 5 minutes (linkerd#1645) Make wait=true a default option for check and dashboard (linkerd#1640) Add version check to Grafana dashboard (linkerd#1638) Add data plane check for metrics Prometheus (linkerd#1635)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch updates the
TopEventTablecomponent with a column to tap each row in the table. It looks like this:Clicking on the icon takes you to the tap page with the form fields pre-populated with metadata from the top row, and it starts the tap immediately on page load.
Fixes #1461.