Make wait=true a default option for check and dashboard#1640
Merged
klingerf merged 3 commits intolinkerd:masterfrom Sep 14, 2018
alenkacz:av/wait-as-default
Merged
Make wait=true a default option for check and dashboard#1640klingerf merged 3 commits intolinkerd:masterfrom alenkacz:av/wait-as-default
klingerf merged 3 commits intolinkerd:masterfrom
alenkacz:av/wait-as-default
Conversation
Signed-off-by: Alena Varkockova <[email protected]>
Contributor
|
@alenkacz Thanks for submitting this! Sorry this wasn't specified in the ticket, but I'd prefer to keep the |
Member
|
I agree. Sorry @alenkacz I should've been more specific in the issue description! |
Member
What do you think about I'm imagining that in CI, etc, it would be nice to say |
Contributor
Contributor
Author
Signed-off-by: Alena Varkockova <[email protected]>
Signed-off-by: Alena Varkockova <[email protected]>
Contributor
Author
|
@klingerf fixed and added wait=true also for dashboard |
alenkacz
changed the title
klingerf
approved these changes
Sep 14, 2018
zachalbert
added a commit
to zachalbert/linkerd2
that referenced
this pull request
Sep 15, 2018
* master: Move more info from the tap table into the expanded row (linkerd#1641) `linkerd check` sends params on version check (linkerd#1642) Bikeshed the tap and top icons (linkerd#1637) Add link to tap each row in top table (linkerd#1643) Bump default check retry time to 5 minutes (linkerd#1645) Make wait=true a default option for check and dashboard (linkerd#1640) Add version check to Grafana dashboard (linkerd#1638) Add data plane check for metrics Prometheus (linkerd#1635)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1618
Signed-off-by: Alena Varkockova [email protected]