Conversation
41da225 to
691610e
Compare
|
I think we should remove the "Linkerd is a ..." text entirely, and have it read purely "Running Linkerd vx.x.x. Linkerd is up to date." (Don't forget the trailing period!) |
|
@wmorgan we don't use trailing periods on the web dashboard... shall I make them consistent? which way? |
|
Since we have multiple sentences at this point, my preference is to add trailing periods and make everything a real sentence, just like how you have the original screenshot in this PR. |
|
@siggy could you change from You'll want to switch over to promises as well as part of that: fetch(localReqURL, { credentials: 'include' })
.then() |
The web dashboard checks the local Linkerd version against the latest release, and informs the user if an update is available. Grafana was not doing this. Modify the Grafana dashboard to perform a version check, and prompt the user to update if needed. Fixes #1607 Signed-off-by: Andrew Seigner <[email protected]>
195d9e2 to
716c66b
Compare
grampelberg
left a comment
There was a problem hiding this comment.
It would be nice to have as a footer on every page. Otherwise, working great!
rmars
left a comment
There was a problem hiding this comment.
🌟 lgtm!
Note that you could use more of the arrow functions in your code instead of function (right now you have a mixture of both styles), e.g.
.then(function(json) { could be .then(json => {
and .then(function(html) { could be .then(html => {
Signed-off-by: Andrew Seigner <[email protected]>
Signed-off-by: Andrew Seigner <[email protected]>
* master: Move more info from the tap table into the expanded row (linkerd#1641) `linkerd check` sends params on version check (linkerd#1642) Bikeshed the tap and top icons (linkerd#1637) Add link to tap each row in top table (linkerd#1643) Bump default check retry time to 5 minutes (linkerd#1645) Make wait=true a default option for check and dashboard (linkerd#1640) Add version check to Grafana dashboard (linkerd#1638) Add data plane check for metrics Prometheus (linkerd#1635)

The web dashboard checks the local Linkerd version against the latest
release, and informs the user if an update is available. Grafana was not
doing this.
Modify the Grafana dashboard to perform a version check, and prompt the
user to update if needed.
Fixes #1607
Signed-off-by: Andrew Seigner [email protected]
Open question: Do we want this on the top-line dashboard, or on every Grafana dashboard?
Since the code change is embedded in a single line in the Grafana dashboard, I'll include it here also for easier review: