Conversation
Signed-off-by: Alex Leong <[email protected]>
|
I'm good with these, but I went and looked for maybe a couple other options. Some ideas:
Some slightly more out there ideas:
|
|
I like |
|
That's awesome, I was looking for some kind of Sherlock icon, microscope is
perfect.
…On Wed, Sep 12, 2018 at 4:31 PM Alex Leong ***@***.***> wrote:
I like stream for top! Another idea: microscope for tap.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1637 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC7eLwRMK4m6VkTsSfTo-u5sA4bGiNHks5uaZlNgaJpZM4WmTf5>
.
|
|
Yayyy, thanks for fixing these. I couldn't really think of good ones when I added this so I chose super arbitrarily. |
|
do we have fontawesome icons? |
|
I don't think we actually have them anywhere right now, but we used to? They shouldn't be too bad to add. |
|
Looks like we're still importing the font-awesome css, here: But we'd need to upgrade to the latest version to get the microscope icon. I'm planning on doing this as part of #1461. |
|
I like microscope a lot! Stream is good too! |
* master: Move more info from the tap table into the expanded row (linkerd#1641) `linkerd check` sends params on version check (linkerd#1642) Bikeshed the tap and top icons (linkerd#1637) Add link to tap each row in top table (linkerd#1643) Bump default check retry time to 5 minutes (linkerd#1645) Make wait=true a default option for check and dashboard (linkerd#1640) Add version check to Grafana dashboard (linkerd#1638) Add data plane check for metrics Prometheus (linkerd#1635)
4 participants
I find the tap and top icons a bit strange. Using the filter icon for tap is weird because we already use the filter icon for filtering columns. The caret-up icon looks weird to me for top because it looks like something that is click to expand.
Unfortunately, the alternatives aren't super great either. Here are some possibilities I could think of:
For tap:
eye(although this sometimes indicates show/hide... and it also just looks weird)phoneshower(too whimsical?)For top:
table(looks like a calendar)list-olarrow-upThoughts?
Signed-off-by: Alex Leong [email protected]