Improve top table to better cope with high RPS traffic#1634
Merged
Conversation
rmars
force-pushed
the
rmars/top-frenzy
branch
from
3149112 to
40f9614
Compare
rmars
force-pushed
the
rmars/top-frenzy
branch
from
40f9614 to
488d891
Compare
dadjeibaah
approved these changes
Sep 12, 2018
Contributor
dadjeibaah
left a comment
dadjeibaah
left a comment
There was a problem hiding this comment.
LGTM 📦 Left a comment but not a big deal.
Contributor
|
Small UI nit, but I don't think it's a big deal. If the Top table is displayed on a really wide monitor the success rate has some padding to the right that makes it look like this: |
Author
|
Hmmm I think you have an old branch? I did rebase on top of master (since I merged two branches that had conflicted with this), so if you checked it out before I'd done that you'd see an old version, without the success rate chart. |
zachalbert
added a commit
to zachalbert/linkerd2
that referenced
this pull request
Sep 13, 2018
* master: Update CHANGES.md for v18.9.1 release (linkerd#1631) Cleanly shutdown tap stream to data plane proxies (linkerd#1624) Change breadcrumb header to default font in styles.css (linkerd#1633) Improve top table to better cope with high RPS traffic (linkerd#1634) Add small success rate chart to table, misc web tweaks (linkerd#1628) Consolidate the source and destination columns in the Tap and Top tables (linkerd#1620) remove extraneous calc function in sidebar.css (linkerd#1632) Display more helpful websocket errors (linkerd#1626) Add breadcrumb navigation at the top of linkerd dashboard (linkerd#1613) Introduce inject check for known sidecars (linkerd#1619) Bump Prometheus to v2.4.0, Grafana to 5.2.4 (linkerd#1625) Improve performance of tap table by throttling updates (linkerd#1623) Add with-source flag to top (linkerd#1614) Conflicts: web/app/css/styles.css web/app/js/components/ResourceDetail.jsx web/app/js/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two variables we use to control the volume of Top output, maxRowsToDisplay, which controls how many rows are in the table, and maxRowsToStore, which controls the size of the event index we keep in memory for aggregating results.
Previously, we were only keeping in index maxRowsToDisplay rows, which for the Resource Detail page was 10 (which is really small for high traffic rest-y resource traffic - it causes rows to be deleted from the index too soon, and then causes the data in the table to change a lot). Change this to store maxRowsToStore rows, and also bump this to 50. This allows us to store results for longer, and also ensures more consistent data over time.
Another fix for the appearance of the Top columns is to add fixed widths to the metrics. This will prevent the table from wobbling from side to side. Some widths were added in #1620 and #1628 though, so it'd be helpful to look at widths again once these three branches have merged.
Fixes #1601