Skip to content

Follow up to fix extraneous css style in sidebar css.#1632

Merged
dadjeibaah merged 1 commit intomasterfrom
dad/follow-up-fix-breadcrumb-css
Sep 12, 2018
Merged

Follow up to fix extraneous css style in sidebar css.#1632
dadjeibaah merged 1 commit intomasterfrom
dad/follow-up-fix-breadcrumb-css

Conversation

@dadjeibaah
Copy link
Contributor

This PR is a result of a change request that was missed in PR #1613. This change removes an unnecessary calc() function in the sidebar.css

Signed-off-by: Dennis Adjei-Baah [email protected]

Signed-off-by: Dennis Adjei-Baah <[email protected]>
@dadjeibaah dadjeibaah self-assigned this Sep 12, 2018
@dadjeibaah dadjeibaah requested a review from rmars September 12, 2018 18:23
Copy link

@rmars rmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 🚀

@dadjeibaah dadjeibaah merged commit b10b8cb into master Sep 12, 2018
@dadjeibaah dadjeibaah deleted the dad/follow-up-fix-breadcrumb-css branch September 12, 2018 18:38
zachalbert added a commit to zachalbert/linkerd2 that referenced this pull request Sep 13, 2018
* master:
  Update CHANGES.md for v18.9.1 release (linkerd#1631)
  Cleanly shutdown tap stream to data plane proxies (linkerd#1624)
  Change breadcrumb header to default font in styles.css (linkerd#1633)
  Improve top table to better cope with high RPS traffic (linkerd#1634)
  Add small success rate chart to table, misc web tweaks (linkerd#1628)
  Consolidate the source and destination columns in the Tap and Top tables (linkerd#1620)
  remove extraneous calc function in sidebar.css (linkerd#1632)
  Display more helpful websocket errors (linkerd#1626)
  Add breadcrumb navigation at the top of linkerd dashboard (linkerd#1613)
  Introduce inject check for known sidecars (linkerd#1619)
  Bump Prometheus to v2.4.0, Grafana to 5.2.4 (linkerd#1625)
  Improve performance of tap table by throttling updates (linkerd#1623)
  Add with-source flag to top (linkerd#1614)

Conflicts:
	web/app/css/styles.css
	web/app/js/components/ResourceDetail.jsx
	web/app/js/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants