Without propagating the context from the client request, how do the proxy tap requests ever get cancelled?

From my reading of the gRPC GoDocs DialContext usesctx the set up of the connection and the ctx struct doesn't manage the lifetime of the connection. IIUC, that means there is no need for the proxy tap requests to use the parent ctx provided by the TapByResource. The thought process is that each connection to a data plane tap should have its own context and when the connection is closed the context is canceled with it.

I am not sure what the difference is between Dial and DialContext but we could probably get away with just using Dial when creating a connection since it provides its own context.

I'm wondering if a better solution would be to get rid of this goroutine altogether and instead add a switch when reading from the events channel so that we read from both the events channel and the context's Done channel and return when Done becomes closed. I think this has the intended behavior without needing to worry about closing the events channel.

That is a good point. We would need to wrap the select in a infinite loop so that we don't exit the function in the event where we don't receive any events and the stream context isn't marked as Done()