Add test for inbound policy index deletion#12143
Merged
Conversation
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
mateiidavid
approved these changes
Mar 1, 2024
| ); | ||
| test.index.write().apply(server.clone()); | ||
|
|
||
| let authz = ClientAuthorization { |
Member
There was a problem hiding this comment.
this is really nitpicky but it was immediately clear to me that this is only used at the end as the expected configuration (i.e. expected InboundServer authz policy). Maybe moving it closer to the assert or naming it more explicitly might help.
Ultimately once you go through this test top-to-bottom once or twice it starts to add up anyway so I don't think it's a major problem and will just leave it up to you.
alpeb
reviewed
Mar 4, 2024
Signed-off-by: Alex Leong <[email protected]>
alpeb
approved these changes
Mar 7, 2024
GrigoriyMikhalkin
pushed a commit
to GrigoriyMikhalkin/linkerd2
that referenced
this pull request
Mar 10, 2024
PR linkerd#12088 fixed an issue where removing and then re-adding certain policy resources could leave the policy index in an incorrect state. We add a test for the specific condition that triggered this behavior to prevent against future regressions. Verified that this test fails prior to linkerd#12088 but passes on main. Signed-off-by: Alex Leong <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #12088 fixed an issue where removing and then re-adding certain policy resources could leave the policy index in an incorrect state. We add a test for the specific condition that triggered this behavior to prevent against future regressions.
Verified that this test fails prior to #12088 but passes on main.