ignore proxy imagees with digests when checking version#12059
Merged
Conversation
Signed-off-by: Alex Leong <[email protected]>
mateiidavid
approved these changes
Feb 13, 2024
Member
mateiidavid
left a comment
mateiidavid
left a comment
There was a problem hiding this comment.
LGTM. Seems like a good way to do it due to the reasons you've mentioned in the description.
Merged
adleong
added a commit
that referenced
this pull request
Feb 16, 2024
* Allowed the `MutatingWebhookConfig` timeout value to be configured ([#12028]) (thanks @mikebell90) * Added a counter for items dropped from destination controller workqueue ([#12079]) * Fixed a spurious `linkerd check` error when using container images with digests ([#12059]) * Fixed an issue where inbound policy could be incorrect after certain policy resources are deleted ([#12088]) [#12028]: #12028 [#12079]: #12079 [#12059]: #12059 [#12088]: #12088 Signed-off-by: Alex Leong <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12058
When proxy images are specified by digest rather than by tag,
linkerd checkwill erroneously assume that the digest is a tag and attempt to compare it to the current Linkerd version.Instead, we ignore images with digests since there isn't an easy way to determine what version a digest corresponds to.