Enable Authorities in web UI, under /authorities#1189
Merged
rmars merged 2 commits intormars/authorityfrom Jun 26, 2018
Merged
Conversation
rmars
commented
Jun 22, 2018
rmars
commented
klingerf
approved these changes
Jun 22, 2018
Contributor
klingerf
left a comment
klingerf
left a comment
There was a problem hiding this comment.
⭐️ Looks good! I just had one comment about the namespace column for authorities.
| let resource = this.props.resource.toLowerCase(); | ||
|
|
||
| let showNsColumn = this.props.showNamespaceColumn; | ||
| if (resource === "authority" || resource === "namespace") { |
Contributor
There was a problem hiding this comment.
I think we should be able to display the namespace column on the authority list page and have it be meaningful. Am pretty sure that will work with the refactor suggested on #1181.
rmars
force-pushed
the
rmars/ui-authority
branch
from
3992b5f to
07afbc9
Compare
Author
|
Added!
|
klingerf
approved these changes
Jun 26, 2018
Contributor
klingerf
left a comment
klingerf
left a comment
There was a problem hiding this comment.
⭐️ Looks great, thanks for updating!
rmars
force-pushed
the
rmars/ui-authority
branch
from
07afbc9 to
14f7fb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.