Add PDB on linkerd-viz Helm chart#11628
Merged
alpeb merged 2 commits intolinkerd:mainfrom Nov 23, 2023
Merged
Conversation
To avoid disruption during cluster nodes rolling or scaling, it's desired to complement the maxUnavailable from the rolling strategy with a PodDisruptionBudget. This commit adds the respective PDB objects following the core components implementation to the `tap` and `tap-injector` deployments. It can be enabled with the enablePodDisruptionBudget helm chart value. Fixes linkerd#11248 Signed-off-by: Matias Charriere <[email protected]>
alpeb
reviewed
Nov 21, 2023
viz/charts/linkerd-viz/values.yaml
Outdated
| # Enable this only when you have multiple replicas of components. | ||
| enablePodAntiAffinity: false | ||
|
|
||
| # -- enables the creation of pod disruption budgets for tap and tap-injector components |
Member
There was a problem hiding this comment.
Can you please add web to the list, and re-run bin/helm-docs?
Contributor
Author
There was a problem hiding this comment.
done. also added metrics-api.
Signed-off-by: Matias Charriere <[email protected]>
mcharriere
force-pushed
the
pdb-linkerd-viz
branch
from
90d630f to
742a730
Compare
mateiidavid
added a commit
that referenced
this pull request
Nov 30, 2023
This edge release introduces new configuration values in the identity controller for client-go's `QPS` and `Burst` settings. Default values for these settings have also been raised from `5` (QPS) and `10` (Burst) to `100` and `200` respectively. * Added `namespaceSelector` fields for the tap-injector and jaeger-injector webhooks. The webhooks are now configured to skip `kube-system` by default ([#11649]; fixes [#11647]) (thanks @mikutas!) * Added the ability to configure client-go's `QPS` and `Burst` settings in the identity controller ([#11644]) * Improved client-go logging visibility throughout the control plane's components ([#11632]) * Introduced `PodDisruptionBudgets` in the linkerd-viz Helm chart for tap and tap-injector ([#11628]; fixes [#11248]) (thanks @mcharriere!) [#11649]: #11649 [#11647]: #11647 [#11644]: #11644 [#11632]: #11632 [#11628]: #11628 [#11248]: #11248 Signed-off-by: Matei David <[email protected]>
Merged
mateiidavid
added a commit
that referenced
this pull request
Dec 1, 2023
This edge release introduces new configuration values in the identity controller for client-go's `QPS` and `Burst` settings. Default values for these settings have also been raised from `5` (QPS) and `10` (Burst) to `100` and `200` respectively. * Added `namespaceSelector` fields for the tap-injector and jaeger-injector webhooks. The webhooks are now configured to skip `kube-system` by default ([#11649]; fixes [#11647]) (thanks @mikutas!) * Added the ability to configure client-go's `QPS` and `Burst` settings in the identity controller ([#11644]) * Improved client-go logging visibility throughout the control plane's components ([#11632]) * Introduced `PodDisruptionBudgets` in the linkerd-viz Helm chart for tap and tap-injector ([#11628]; fixes [#11248]) (thanks @mcharriere!) [#11649]: #11649 [#11647]: #11647 [#11644]: #11644 [#11632]: #11632 [#11628]: #11628 [#11248]: #11248 Signed-off-by: Matei David <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid disruption during cluster nodes rolling or scaling, it's desired to complement the maxUnavailable from the rolling strategy with a PodDisruptionBudget.
This commit adds the respective PDB objects following the core components implementation to the
tap,tap-injector,webandmetrics-apideployments. It can be enabled with the enablePodDisruptionBudget helm chart value and are installed only if each of those components have more than 1 replica.Fixes #11248
Previous PR was close due inactivity (#11249), sorry about that.
As requested there, I added in this new PR PDBs for
webandmetrics-api.prometheushas only fixed 1 replica; so it doesn't really make sense to add a PDB for it.