Remove k8sAPI/metadataAPI dependency from endpointProfileTranslator#11587
Merged
Remove k8sAPI/metadataAPI dependency from endpointProfileTranslator#11587
Conversation
This removes `endpointProfileTranslator`'s dependency on the k8sAPI and metadataAPI, which are not used. This was introduced in one of #11334's refactorings, but ended up being not required. No functional changes here.
mateiidavid
approved these changes
Nov 8, 2023
Member
mateiidavid
left a comment
mateiidavid
left a comment
There was a problem hiding this comment.
Looks good. I haven't tested everything works. My assumption is that if those were used we'd bump into compile time issues anyway so it seems safe to take them out 👍🏻
adleong
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
endpointProfileTranslator's dependency on the k8sAPI and metadataAPI, which are not used. This was introduced in one of #11334's refactorings, but ended up being not required. No functional changes here.