Merged
Conversation
This edge release includes a fix for the `ServiceProfile` CRD resource schema. The schema incorrectly required `not` response matches to be arrays, while the in-cluster validator parsed `not` response matches as objects. In addition, an issues has been fixed in `linkerd profile`. When used with the `--open-api` flag, it would not strip trailing slashes when generating a resource from swagger specifications. * Fixed an issue where trailing slashes wouldn't be stripped when generating `ServiceProfile` resources through `linkerd profile --open-api` ([#11519]) * Fixed an issue in the `ServiceProfile` CRD schema. The schema incorrectly required that a `not` response match should be an array, which the service profile validator rejected since it expected an object. The schema has been updated to properly indicate that `not` values should be an object ([#11510]; fixes [#11483]) * Improved logging in the destination controller by adding the client pod's name to the logging context. This will improve visibility into the messages sent and received by the control plane from a specific proxy ([#11532]) * Fixed an issue in the destination controller where the metadata API would not initialize a `Job` informer. The destination controller uses the metadata API to retrieve `Job` metadata, and relies mostly on informers. Without an initialized informer, an error message would be logged, and the controller relied on direct API calls ([#11541]; fixes [#11531]) [#11541]: #11532 [#11532]: #11532 [#11531]: #11531 [#11519]: #11519 [#11510]: #11510 [#11483]: #11483 Signed-off-by: Matei David <[email protected]>
Signed-off-by: Matei David <[email protected]>
Member
Author
|
Note: you'll see some changes made to the previous edge's notes. The issue reference # (for the destination queue update) was wrong and it pointed to the SP fix. Changed it to the actual # it was supposed to reference so I can pass the markdown lint step. |
adleong
approved these changes
Oct 27, 2023
alpeb
reviewed
Oct 27, 2023
charts/linkerd-crds/Chart.yaml
Outdated
| version: 0.1.0 | ||
| repository: file://../partials | ||
| version: 1.8.0 | ||
| version: 1.8.1-edge |
Member
There was a problem hiding this comment.
Needs to be 1.9.0-edge instead, so that if there's change in CRDs somewhere in 2.14.x, it can be bumped in that branch without appearing after this edge.
alpeb
approved these changes
Oct 27, 2023
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
LGTM modulo linkerd-crds chart version
Signed-off-by: Matei David <[email protected]>
Signed-off-by: Matei David <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This edge release includes a fix for the
ServiceProfileCRD resource schema. The schema incorrectly requirednotresponse matches to be arrays, while the in-cluster validator parsednotresponse matches as objects. In addition, an issues has been fixed inlinkerd profile. When used with the--open-apiflag, it would not strip trailing slashes when generating a resource from swagger specifications.ServiceProfileresources throughlinkerd profile --open-api(#11519)ServiceProfileCRD schema. The schema incorrectly required that anotresponse match should be an array, which the service profile validator rejected since it expected an object. The schema has been updated to properly indicate thatnotvalues should be an object (#11510; fixes #11483)Jobinformer. The destination controller uses the metadata API to retrieveJobmetadata, and relies mostly on informers. Without an initialized informer, an error message would be logged, and the controller relied on direct API calls (#11541; fixes #11531)