Bump proxy-init:v2.2.3 and cni-plugin:v1.2.2#11399
Merged
Conversation
https://github.com/linkerd/linkerd2-proxy-init/releases/tag/proxy-init%2Fv2.2.3 https://github.com/linkerd/linkerd2-proxy-init/releases/tag/cni-plugin%2Fv1.2.2 Updated to use go 1.21
mateiidavid
approved these changes
Sep 21, 2023
olix0r
reviewed
Sep 21, 2023
| | profileValidator.injectCaFromSecret | string | `""` | Inject the CA bundle from a Secret. If set, the `cert-manager.io/inject-ca-from-secret` annotation will be added to the webhook. The Secret must have the CA Bundle stored in the `ca.crt` key and have the `cert-manager.io/allow-direct-injection` annotation set to `true`. See the cert-manager [CA Injector Docs](https://cert-manager.io/docs/concepts/ca-injector/#injecting-ca-data-from-a-secret-resource) for more information. | | ||
| | profileValidator.keyPEM | string | `""` | Certificate key for the service profile validator. If not provided and not using an external secret then Helm will generate one. | | ||
| | profileValidator.namespaceSelector | object | `{"matchExpressions":[{"key":"config.linkerd.io/admission-webhooks","operator":"NotIn","values":["disabled"]}]}` | Namespace selector used by admission webhook | | ||
| | prometheusUrl | string | `""` | url of external prometheus instance (used for the heartbeat) | |
Member
There was a problem hiding this comment.
This seems unrelated to proxyInit?
Member
There was a problem hiding this comment.
It's from a previous change where bin/helm-docs wasn't run. Seems to be unavoidable when generating the docs. For the backport it might be okay, if the field isn't present in values.yaml it will get removed once we bump the charts and re-generate the docs.
@alpeb does that sound right to you?
Member
Author
There was a problem hiding this comment.
I don't understand why the doc diff wasn't caught by CI in earlier runs, but it looks like this PR puts it back in track.
olix0r
approved these changes
Sep 21, 2023
mateiidavid
pushed a commit
that referenced
this pull request
Sep 21, 2023
https://github.com/linkerd/linkerd2-proxy-init/releases/tag/proxy-init%2Fv2.2.3 https://github.com/linkerd/linkerd2-proxy-init/releases/tag/cni-plugin%2Fv1.2.2 Updated to use go 1.21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/linkerd/linkerd2-proxy-init/releases/tag/proxy-init%2Fv2.2.3
https://github.com/linkerd/linkerd2-proxy-init/releases/tag/cni-plugin%2Fv1.2.2
Dependency bumps and updated go to v1.21