Add informative error messages when there is no internet connection.#11377
Merged
olix0r merged 3 commits intolinkerd:mainfrom Sep 26, 2023
dtaskai:main
Merged
Add informative error messages when there is no internet connection.#11377olix0r merged 3 commits intolinkerd:mainfrom dtaskai:main
olix0r merged 3 commits intolinkerd:mainfrom
dtaskai:main
Conversation
Signed-off-by: Dominik Táskai <[email protected]>
adleong
reviewed
Sep 18, 2023
Member
adleong
left a comment
adleong
left a comment
There was a problem hiding this comment.
Nice, thanks for fixing this. I have just a few minor code cleanliness suggestions.
Signed-off-by: Dominik Táskai <[email protected]>
Contributor
Author
|
@adleong Definitely agree with all of them, thank you very much for the insights! |
adleong
approved these changes
Sep 25, 2023
Member
adleong
left a comment
adleong
left a comment
There was a problem hiding this comment.
Nice! Thanks for this change!
mateiidavid
approved these changes
Sep 26, 2023
Member
mateiidavid
left a comment
mateiidavid
left a comment
There was a problem hiding this comment.
Looks good. None of my comments are blocking.
Merged
olix0r
added a commit
that referenced
this pull request
Sep 29, 2023
This edge release makes Linkerd even better. * Added a controlPlaneVersion override to the `linkerd-control-plane` Helm chart to support including SHA256 image digests in Linkerd manifests (thanks @cromulentbanana!) ([#11406]) * Improved `linkerd viz check` to attempt to validate that the Prometheus scrape interval will work well with the CLI and Web query parameters ([#11376]) * Improved CLI error handling to print differentiated error information when versioncheck.linkerd.io cannot be resolved (thanks @dtaskai) ([#11377]) * Fixed an issue where the destination controller would not update pod metadata for profile resolutions for a pod accessed via the host network (e.g. HostPort endpoints) ([#11334]). * Added a validating webhook config for httproutes.gateway.networking.k8s.io resources (thanks @mikutas!) ([#11150]) * Introduced a new `multicluster check --timeout` flag to limit the time allowed for Kubernetes API calls (thanks @moki1202) ([#11420]) [#11150]: #11150 [#11334]: #11334 [#11376]: #11376 [#11377]: #11377 [#11406]: #11406 [#11420]: #11420
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a way to narrow down the errors to a lack of internet connection for the proxy version check and also an additional check when matching the channels and last but not least identifying a DNS error when getting the latest versions.
If this happens to be merged then I'd happily update the docs in the errors' respective places to let the users know that they should check their connections as it is not currently listed as a possible solution to the issues.
Sample output with the submitted solution:
pr-validation-output.txt
Fixes #11349