Skip to content

re-enable go format checking in CI#11363

Merged
adleong merged 3 commits intomainfrom
alex/fmt
Sep 14, 2023
Merged

re-enable go format checking in CI#11363
adleong merged 3 commits intomainfrom
alex/fmt

Conversation

@adleong
Copy link
Member

@adleong adleong commented Sep 11, 2023

A git related "dubious ownership" error was preventing the go format action from running in CI. As a result of go formatting not getting checked in CI, some go formatting drift has been introduced.

Add the appropriate git config command to resolve dubious ownership so that go format checking is run in CI.

@adleong adleong requested a review from a team as a code owner September 11, 2023 23:56
@adleong
Copy link
Member Author

adleong commented Sep 12, 2023

Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
@adleong adleong merged commit fe9532b into main Sep 14, 2023
@adleong adleong deleted the alex/fmt branch September 14, 2023 20:13
adamshawvipps pushed a commit to adamshawvipps/linkerd2 that referenced this pull request Sep 18, 2023
A git related "dubious ownership" error was preventing the go format action from running in CI. As a result of go formatting not getting checked in CI, some go formatting drift has been introduced.

Add the appropriate git config command to resolve dubious ownership so that go format checking is run in CI.

Signed-off-by: Alex Leong <[email protected]>
adamshawvipps pushed a commit to adamshawvipps/linkerd2 that referenced this pull request Sep 18, 2023
A git related "dubious ownership" error was preventing the go format action from running in CI. As a result of go formatting not getting checked in CI, some go formatting drift has been introduced.

Add the appropriate git config command to resolve dubious ownership so that go format checking is run in CI.

Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Adam Shaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants