Conversation
lingui/cli manages locales, extracts messages from source files and compiles message catalogs for production use. Dependabot's bump seems to fail since lingui/cli requires at least node v16, and the current Dockerfile uses node v14. This change updates the web dockerfile to use node v20 and also configures the JS web test runner to use node v20. Lingui/cli's migration docs are covered in https://lingui.dev/releases/migration-4#backward-incompatible-changes for migrating from v3.x.x to v4.x.x. Signed-off-by: Matei David <[email protected]>
Signed-off-by: Matei David <[email protected]>
alpeb
reviewed
Sep 6, 2023
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
LGTM, but my understanding is that bookworm is the latest Debian stable, did you try using that?
Member
Author
|
ah, good spot, I've fallen off the debian release chart. I haven't but I think it's safe to use bookworm, the runtime for node is still the same. |
Signed-off-by: Matei David <[email protected]>
alpeb
approved these changes
Sep 7, 2023
adleong
reviewed
Sep 8, 2023
Member
adleong
left a comment
adleong
left a comment
There was a problem hiding this comment.
It looks like codecov.yml also uses node:14-stretch. Do we want to update that as well?
Signed-off-by: Matei David <[email protected]>
Member
Author
That's probably a good idea, updated the PR. |
adleong
approved these changes
Sep 11, 2023
adamshawvipps
pushed a commit
to adamshawvipps/linkerd2
that referenced
this pull request
Sep 18, 2023
lingui/cli manages locales, extracts messages from source files and compiles message catalogs for production use. Dependabot's bump seems to fail since lingui/cli requires at least node v16, and the current Dockerfile uses node v14. This change updates the web dockerfile to use node v20 and also configures the JS web test runner to use node v20. Lingui/cli's migration docs are covered in https://lingui.dev/releases/migration-4#backward-incompatible-changes for migrating from v3.x.x to v4.x.x. Signed-off-by: Matei David <[email protected]>
adamshawvipps
pushed a commit
to adamshawvipps/linkerd2
that referenced
this pull request
Sep 18, 2023
lingui/cli manages locales, extracts messages from source files and compiles message catalogs for production use. Dependabot's bump seems to fail since lingui/cli requires at least node v16, and the current Dockerfile uses node v14. This change updates the web dockerfile to use node v20 and also configures the JS web test runner to use node v20. Lingui/cli's migration docs are covered in https://lingui.dev/releases/migration-4#backward-incompatible-changes for migrating from v3.x.x to v4.x.x. Signed-off-by: Matei David <[email protected]> Signed-off-by: Adam Shaw <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lingui/cli manages locales, extracts messages from source files and compiles message catalogs for production use. Dependabot's bump seems to fail since lingui/cli requires at least node v16, and the current Dockerfile uses node v14.
This change updates the web dockerfile to use node v20 and also configures the JS web test runner to use node v20.
Lingui/cli's migration docs are covered in
https://lingui.dev/releases/migration-4#backward-incompatible-changes for migrating from v3.x.x to v4.x.x.