added liveness and readiness probes to debug container partials template#11308
Merged
alpeb merged 6 commits intolinkerd:mainfrom Nov 3, 2023
Merged
Conversation
Signed-off-by: Alen Haric <[email protected]>
Signed-off-by: Alen Haric <[email protected]>
Signed-off-by: Alen Haric <[email protected]>
olix0r
requested changes
Aug 31, 2023
Signed-off-by: Matei David <[email protected]>
Signed-off-by: Matei David <[email protected]>
…n, updated golden files
alpeb
approved these changes
Oct 24, 2023
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
I've replaced the commands with just true, fixed the golden files and the pod-with-debug.patch.json file 🙏
adleong
approved these changes
Oct 24, 2023
mateiidavid
approved these changes
Oct 25, 2023
olix0r
approved these changes
Nov 3, 2023
alpeb
added a commit
that referenced
this pull request
Nov 9, 2023
## edge-23.11.2 This edge release contains observability improvements and bug fixes to the Destination controller, and a refinement to the multicluster gateway resolution logic. * Fixed an issue where the Destination controller could stop processing service profile updates, if a proxy subscribed to those updates stops reading them; this is a followup to the issue [#11491] fixed in edge-23.10.3 ([#11546]) * In the Destination controller, added informer lag histogram metrics to track whenever the objects tracked are falling behind the state in the kube-apiserver ([#11534]) * In the multicluster service mirror, extended the target gateway resolution logic to take into account all the possible IPs a hostname might resolve to, not just the first one (thanks @MrFreezeex!) ([#11499]) * Added probes to the debug container to appease environments requiring probes for all containers ([#11308])
alpeb
added a commit
that referenced
this pull request
Nov 9, 2023
## edge-23.11.2 This edge release contains observability improvements and bug fixes to the Destination controller, and a refinement to the multicluster gateway resolution logic. * Fixed an issue where the Destination controller could stop processing service profile updates, if a proxy subscribed to those updates stops reading them; this is a followup to the issue [#11491] fixed in [edge-23.10.3] ([#11546]) * In the Destination controller, added informer lag histogram metrics to track whenever the Kubernetes objects watched by the controller are falling behind the state in the kube-apiserver ([#11534]) * In the multicluster service mirror, extended the target gateway resolution logic to take into account all the possible IPs a hostname might resolve to, rather than just the first one (thanks @MrFreezeex!) ([#11499]) * Added probes to the debug container to appease environments requiring probes for all containers ([#11308]) [edge-23.10.3]: https://github.com/linkerd/linkerd2/releases/tag/edge-23.10.3 [#11546]: #11546 [#11534]: #11534 [#11499]: #11499 [#11308]: #11308
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
added liveness and readiness probes to debug container partials template
Problem
Some environments have security restrictions which require liveness and readiness probes in order to deploy any container in the cluster. Currently our debug container does not contain these, and there is no easy way for users to add the values into the container due to the way it's injected into the pod but not propagated to the deployment.
Solution
Added static liveness and readiness probes to debug container partials template which will always pass and evaluate to true.
Fixes #[11307]
Alen Haric (deusxanima) [email protected]