Add imagePullSecrets to the multicluster chart.#11287
Conversation
Fixes linkerd#11285 Signed-off-by: Louis Haußknecht <[email protected]>
Signed-off-by: Louis Haußknecht <[email protected]>
adleong
left a comment
adleong
left a comment
There was a problem hiding this comment.
Do the gateway and/or ServiceMirror need imagePullSecrets also?
Signed-off-by: Louis Haußknecht <[email protected]>
|
@adleong Added the secret also to the gateway service account. |
|
thanks, @lhaussknecht! This looks great but it's probably not complete until we have image pull secrets for the service mirror controller too, right? Anyone who wants to use the linkerd-multicluster extension in an air gapped environment like this would need image pull secrets for the service mirror controller. The service mirror controller is in the linkerd-multicluster-link helm chart. This isn't a helm chart we publish. Instead, the |
Signed-off-by: Louis Haußknecht <[email protected]>
|
Thanks for the clarification. I added imagePull secrets to the service mirror. |
adleong
left a comment
adleong
left a comment
There was a problem hiding this comment.
Excellent! Thanks for this, @lhaussknecht
Fixes #11285 Add an imagePullSecrets value to the linkerd-multicluster and linkerd-multicluster-link charts so that imagePullSecrets can be specified for the multicluster extension. --------- Signed-off-by: Louis Haußknecht <[email protected]>
* 0a72f1f Add imagePullSecrets to the multicluster chart. (#11287) * 284d76b service-mirror: support gateway resolving to multiple addresses (#11499) * 64bccd9 Improve klog (client-go logs) handling (#11632) * 6a07e2c Add ability to configure client-go's `QPS` and `Burst` settings (#11644) * e294c78 Bump prometheus to v2.48.0 (#11633) * b24b0e97c stable-2.14.6
* 0a72f1f Add imagePullSecrets to the multicluster chart. (#11287) * 284d76b service-mirror: support gateway resolving to multiple addresses (#11499) * 64bccd9 Improve klog (client-go logs) handling (#11632) * 6a07e2c Add ability to configure client-go's `QPS` and `Burst` settings (#11644) * e294c78 Bump prometheus to v2.48.0 (#11633) * b24b0e97c stable-2.14.6
stable-2.14.6 * 0a72f1f Add imagePullSecrets to the multicluster chart. (#11287) * 284d76b service-mirror: support gateway resolving to multiple addresses (#11499) * 64bccd9 Improve klog (client-go logs) handling (#11632) * 6a07e2c Add ability to configure client-go's `QPS` and `Burst` settings (#11644) * e294c78 Bump prometheus to v2.48.0 (#11633)
3 participants
Fixes #11285