Skip to content

Nits around grafana and jaeger fields in params #4349

@Pothulapati

Description

@Pothulapati

Bug Report

With #4177. There is a confusion on grafana being isRequired while jaeger being not, even though they do the same things. The change would be to remove isRequired for grafana and update the tests as they expect grafana field to be there always.

Also, we are not really using grafana and jaeger fields, and just checking if they are empty. Using a boolean would be a better choice here.

What is the issue?

How can it be reproduced?

Logs, error output, etc

(If the output is long, please create a gist and
paste the link here.)

linkerd check output

your output here ...

Environment

  • Kubernetes Version:
  • Cluster Environment: (GKE, AKS, kops, ...)
  • Host OS:
  • Linkerd version:

Possible solution

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions