Skip to content

Client ID in edges command can be wrong #3706

@adleong

Description

@adleong

If you have two or more meshed resources in a single namespace which all send traffic to another meshed resource, the client ids reported in the linkerd edges command can sometimes be mixed up.

For example, consider that you have the linkerd-prometheus and linkerd-web deployments both sending to the linkerd-controller deployment. The linkerd edges command will sometimes report that the edge from linkerd-prometheus will have the linkerd-controller client id or vice versa.

This is because connection data gathered from the dst proxy metrics is keyed by dstResource.srcNamespace. Different src resources in the same namespace will have a key conflict.

More fundamentally, the dst proxy metrics do not include a src_resource label which makes it impossible to reliably associate the dst proxy metrics with the src proxy metrics. Furthermore, metrics from both sides are required because only the src proxy metrics include the server id label and only the dst proxy metrics include the client id label.

This can cause a failure of the edges integration test if the above conditions are met.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions