Background

The ServiceProfile generated client and api code lives under ./controller/gen primarily that is where all generated code is centralized. As non-controller components, namely the CLI, depend on this code, it makes less sense to have it there.

Proposal

Move ServiceProfile generated code into ./pkg.

This would allow us to move NewSpClientSet into pkg/k8s, which would then allow us to make k8s.GetConfig private.

This is a continuation of #2747.