linkerd inject breaks HPA configuration as no requests are set for proxy sidecar #1480
Description
👋
After moving some of our services that use HPA to scale Deployments in k8s, the HPA will not be able to work out the current cpu usage as there is no default requests in the deployment for the linkerd-proxy sidecar that it creates.
Conditions:
Type Status Reason Message
---- ------ ------ -------
AbleToScale True SucceededGetScale the HPA controller was able to get the target's current scale
ScalingActive False FailedGetResourceMetric the HPA was unable to compute the replica count: missing request for cpu on container linkerd-proxy in pod ms/gql-7d485bd799-dnf66
ScalingLimited True TooFewReplicas the desired replica count is increasing faster than the maximum scale rate
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Warning FailedGetResourceMetric 4m (x253 over 2h) horizontal-pod-autoscaler missing request for cpu on container linkerd-proxy in pod ms/gql-7d485bd799-dnf66
Maybe we can add some sensible defaults into the linkerd inject?