linkerd check on host with no internet access gives missleading messages #11349
Description
What is the issue?
linkerd check fails in the following tests because it cannot get the latest version from https://versioncheck.linkerd.io/version.json
- linkerd-version
- control-plane-version
- linkerd-control-plane-proxy
When linkerd check fails the test "linkerd-version" due to no internet access it cannot get the recent version and therefore fails more tests (with a warning), but with irritating messages. The messages indicate that my installation does not have the correct versions - although everything is fine.
linkerd-check-no-internet.txt
linkerd-check-internet.txt
How can it be reproduced?
I used stable-2.14.0, but it also works with earlier versions.
- Install linkerd
- Disable the internet access from the host where you are going to use the linkerd cli
- Login into the cluster
- Use the linkerd cli with
linkerd checkto get the result
You can do the same test and enable the internet access and the output of linkerd check will be correct.
Logs, error output, etc
linkerd-check-no-internet.txt
linkerd-check-internet.txt
output of linkerd check -o short
Environment
Kubernetes Version: Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.8+vmware.3", GitCommit:"53e803785668c31b8fcb41fc3607f3fdc3c87465", GitTreeState:"clean", BuildDate:"2022-11-03T17:16:51Z", GoVersion:"go1.17.11", Compiler:"gc", Platform:"linux/amd64"}
Cluster Environemnt: Tanzu
Host OS: RHEL 8.5
Linkerd Version: stable-2.14.0
Possible solution
It would be great to change the warning messages or to skip the version tests when the latest version is not receivable from the internet or add an option for the cli where I can pass the latest version like
linkerd check -no-versioncheck
or
linkerd check -latest-version=stable-2.14.0
Additional context
Would you like to work on fixing this bug?
None