SR inconsistency in destination metrics #11066
Description
What is the issue?
While debugging #11065 I found something weird. When using v2.13 these failed requests do not count towards the success rate of destination, while in previous versions e.g. v2.11 they did.
How can it be reproduced?
Same as #11065, add the manifests from the gist and see the difference when using 2.13 vs 2.11
Logs, error output, etc
With 2.11:
With 2.13:
output of linkerd check -o short
linkerd-version
---------------
‼ cli is up-to-date
is running version 2.13.4 but the latest stable version is 2.13.5
see https://linkerd.io/2.13/checks/#l5d-version-cli for hints
control-plane-version
---------------------
‼ control plane is up-to-date
is running version 2.13.4 but the latest stable version is 2.13.5
see https://linkerd.io/2.13/checks/#l5d-version-control for hints
linkerd-control-plane-proxy
---------------------------
‼ control plane proxies are up-to-date
some proxies are not running the current version:
* linkerd-destination-6b566cf687-mzs2w (stable-2.13.4)
* linkerd-identity-77bbfc58bb-mgrwh (stable-2.13.4)
* linkerd-proxy-injector-6f5b6c8798-nw9f5 (stable-2.13.4)
see https://linkerd.io/2.13/checks/#l5d-cp-proxy-version for hints
linkerd-viz
-----------
‼ viz extension proxies are up-to-date
some proxies are not running the current version:
* metrics-api-59c76c4d75-vqkw5 (stable-2.13.4)
* prometheus-b7b44d965-dpflx (stable-2.13.4)
* tap-7c8fb95758-tn5zb (stable-2.13.4)
* tap-injector-586d58cf8f-x8t9r (stable-2.13.4)
* web-7cf5484879-9g888 (stable-2.13.4)
see https://linkerd.io/2.13/checks/#l5d-viz-proxy-cp-version for hints
Status check results are √
Environment
- Kubernetes version: 1.26
- Environment: EKS & Minikube
Possible solution
No response
Additional context
No response
Would you like to work on fixing this bug?
None