linkerd.io/helm-release-version annotation with helmfile #10778
Description
What is the issue?
Hi,
We are using helmfile to deploy linkerd charts. Under the covers, Helmfile executes helm upgrade --install for each release and this command is always setting the .Release.Revision to 1 so we always have a diff when using the diff command.
I saw that in the edge-2075 release for some helm charts linkerd.io/helm-release-version annotation has been replaced by checksum/config.
The linkerd.io/helm-release-version annotation only remains in destination and proxy-injector components and I don't know if there is a real need of it
For what I know, for these 2 components we don't need to restart the pods when a config file change so for me it's safe to get ride of this annotation in all the charts.
How can it be reproduced?
Update linkerd helm chart with the helm upgrade --install command
Logs, error output, etc
annotations:
- linkerd.io/helm-release-version: "10"
+ linkerd.io/helm-release-version: "1"
output of linkerd check -o short
~ ❯ linkerd check -o short 15:18:04
linkerd-identity
----------------
‼ issuer cert is valid for at least 60 days
issuer certificate will expire on 2023-04-26T12:15:55Z
see https://linkerd.io/2.13/checks/#l5d-identity-issuer-cert-not-expiring-soon for hints
linkerd-webhooks-and-apisvc-tls
-------------------------------
‼ proxy-injector cert is valid for at least 60 days
certificate will expire on 2023-04-25T16:00:57Z
see https://linkerd.io/2.13/checks/#l5d-proxy-injector-webhook-cert-not-expiring-soon for hints
‼ sp-validator cert is valid for at least 60 days
certificate will expire on 2023-04-25T16:00:57Z
see https://linkerd.io/2.13/checks/#l5d-sp-validator-webhook-cert-not-expiring-soon for hints
‼ policy-validator cert is valid for at least 60 days
certificate will expire on 2023-04-25T16:00:57Z
see https://linkerd.io/2.13/checks/#l5d-policy-validator-webhook-cert-not-expiring-soon for hints
linkerd-version
---------------
‼ cli is up-to-date
is running version 2.13.0 but the latest stable version is 2.13.1
see https://linkerd.io/2.13/checks/#l5d-version-cli for hints
control-plane-version
---------------------
‼ control plane is up-to-date
is running version 2.13.0 but the latest stable version is 2.13.1
see https://linkerd.io/2.13/checks/#l5d-version-control for hints
linkerd-control-plane-proxy
---------------------------
‼ control plane proxies are up-to-date
some proxies are not running the current version:
* linkerd-destination-5cc9ffb48c-gq4ph (stable-2.13.0)
* linkerd-destination-5cc9ffb48c-wtwc9 (stable-2.13.0)
* linkerd-identity-8494dbd577-bpnp9 (stable-2.13.0)
* linkerd-identity-8494dbd577-hz494 (stable-2.13.0)
* linkerd-proxy-injector-cbd45b548-lwns7 (stable-2.13.0)
* linkerd-proxy-injector-cbd45b548-nkzj5 (stable-2.13.0)
see https://linkerd.io/2.13/checks/#l5d-cp-proxy-version for hints
linkerd-multicluster
--------------------
‼ multicluster extension proxies are up-to-date
some proxies are not running the current version:
* linkerd-gateway-6b555c766c-z5wx8 (stable-2.13.0)
* linkerd-gateway-6b555c766c-zm8np (stable-2.13.0)
* linkerd-service-mirror-us-east-2-testing-8d79f659f-r28pv (stable-2.13.0)
see https://linkerd.io/2.13/checks/#l5d-multicluster-proxy-cp-version for hints
linkerd-viz
-----------
‼ tap API server cert is valid for at least 60 days
certificate will expire on 2023-04-25T14:32:41Z
see https://linkerd.io/2.13/checks/#l5d-tap-cert-not-expiring-soon for hints
‼ viz extension proxies are up-to-date
some proxies are not running the current version:
* metrics-api-675cc97768-tlk96 (stable-2.13.0)
* prometheus-5fd775fc66-spj67 (stable-2.13.0)
* tap-865dcff67-s2xxr (stable-2.13.0)
* tap-injector-7f864555cd-9962k (stable-2.13.0)
* web-76776b6c48-qkfdh (stable-2.13.0)
see https://linkerd.io/2.13/checks/#l5d-viz-proxy-cp-version for hints
Environment
Kubernetes 1.25
EKS
Amazon Linux
Linkerd 2.13.0
Possible solution
Remove the linkerd.io/helm-release-version annotation
Additional context
No response
Would you like to work on fixing this bug?
yes