KAFKA-10794 Replica leader election is too slow in the case of too many partitions (apache#9675)

Montyleo · limengmonty · web-flow · commit 10b07575f1c6 · 2020-12-03T10:38:27.000+08:00
Co-authored-by: limengmonty &lt;limengmonty@didichuxing.com&gt;
Reviewers: Chia-Ping Tsai &lt;chia7712@gmail.com&gt;
diff --git a/core/src/main/scala/kafka/controller/KafkaController.scala b/core/src/main/scala/kafka/controller/KafkaController.scala
@@ -2165,7 +2165,8 @@ class KafkaController(val config: KafkaConfig,
           case None => zkClient.getPreferredReplicaElection
         }
 
-        val (knownPartitions, unknownPartitions) = partitions.partition(tp => controllerContext.allPartitions.contains(tp))
+        val allPartitions = controllerContext.allPartitions
+        val (knownPartitions, unknownPartitions) = partitions.partition(tp => allPartitions.contains(tp))
         unknownPartitions.foreach { p =>
           info(s"Skipping replica leader election ($electionType) for partition $p by $electionTrigger since it doesn't exist.")
         }

Original file line number	Diff line number	Diff line change
`@@ -2165,7 +2165,8 @@ class KafkaController(val config: KafkaConfig,`
`2165`	`2165`	`case None => zkClient.getPreferredReplicaElection`
`2166`	`2166`	`}`
`2167`	`2167`
`2168`		`- val (knownPartitions, unknownPartitions) = partitions.partition(tp => controllerContext.allPartitions.contains(tp))`
	`2168`	`+ val allPartitions = controllerContext.allPartitions`
	`2169`	`+ val (knownPartitions, unknownPartitions) = partitions.partition(tp => allPartitions.contains(tp))`
`2169`	`2170`	`unknownPartitions.foreach { p =>`
`2170`	`2171`	`info(s"Skipping replica leader election ($electionType) for partition $p by $electionTrigger since it doesn't exist.")`
`2171`	`2172`	`}`