Default Value Support Prototype (not for review)#70
Closed
shenodaguirguis wants to merge 3 commits intolinkedin:masterfrom
Closed
Default Value Support Prototype (not for review)#70shenodaguirguis wants to merge 3 commits intolinkedin:masterfrom
shenodaguirguis wants to merge 3 commits intolinkedin:masterfrom
Conversation
Author
|
complete default-value support for AVRO PR: #72 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharing the prototype code for reference while reviewing the PRs, and for records.
In this prototype, issue #2039 was reproduced via unit test, and the applied changes confirmed it fixes it and added other tests that default value is being used/returned whenever the field with default value is not manifested. This was tested for primitive as well as complex data types.
@wmoustafa