Skip to content

Commit d24b2db

Browse files
committed
fix
1 parent 61db91c commit d24b2db

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

codec.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ func NewCodecForStandardJSONFull(schemaSpecification string) (*Codec, error) {
225225
buildCodecForTypeDescribedByMap,
226226
buildCodecForTypeDescribedByString,
227227
buildCodecForTypeDescribedBySliceTwoWayJSON,
228-
}, nil)
228+
}, DefaultCodecOption())
229229
}
230230

231231
func NewCodecFrom(schemaSpecification string, cb *codecBuilder, o *CodecOption) (*Codec, error) {

record.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func makeRecordCodec(st map[string]*Codec, enclosingNamespace string, schemaMap
107107
defaultValue = v
108108
case "union":
109109
// When codec is union, then default value ought to encode using first schema in union.
110-
// NOTE: To support a null default value, the string literal "null" must be coerced to a `nil` when WithStringNull = `true`
110+
// NOTE: To support a null default value, the string literal "null" must be coerced to a `nil` when `EnableStringNull` = `true`
111111
// see https://github.com/linkedin/goavro/issues/280
112112
if o.EnableStringNull && defaultValue == "null" {
113113
defaultValue = nil

0 commit comments

Comments
 (0)