Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new feature to display build information in the footer, including the target framework and build timestamp. The feature is controlled by a new ShowBuildInformation configuration setting (defaulting to true).
- Integrates the
LinkDotNet.BuildInformationNuGet package (v2.0.0) - Adds
ShowBuildInformationconfiguration property with default value of true - Updates the Footer component to display build details when enabled
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/LinkDotNet.Blog.Web/ApplicationConfiguration.cs |
Adds ShowBuildInformation property to configuration model |
src/LinkDotNet.Blog.Web/appsettings.json |
Adds default ShowBuildInformation setting |
src/LinkDotNet.Blog.Web/Features/Home/Components/Footer.razor |
Updates footer to conditionally display build information (framework and timestamp) |
src/LinkDotNet.Blog.Web/LinkDotNet.Blog.Web.csproj |
Adds reference to LinkDotNet.BuildInformation package |
Directory.Packages.props |
Specifies version 2.0.0 for the BuildInformation package |
tests/LinkDotNet.Blog.TestUtilities/ApplicationConfigurationBuilder.cs |
Updates test builder to support ShowBuildInformation property |
tests/LinkDotNet.Blog.UnitTests/Web/ApplicationConfigurationTests.cs |
Adds test assertion for ShowBuildInformation configuration mapping |
docs/Setup/Configuration.md |
Documents the new ShowBuildInformation configuration option |
MIGRATION.md |
Adds migration notes for the 11.0 to 12.0 version upgrade |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
9
to
15
| @if (AppConfiguration.Value.ShowBuildInformation) | ||
| { | ||
| <p class="text-gray-300 mb-0">Made with ❤️, @BuildInformation.TargetFrameworkMoniker, and Blazor</p> | ||
| <p class="text-gray-300"> | ||
| Build At: @(BuildInformation.BuildAt.ToString("dd-MM-yyyy HH:mm")) (UTC) | ||
| </p> | ||
| } |
There was a problem hiding this comment.
The new ShowBuildInformation feature in the Footer component lacks test coverage. Consider adding tests to FooterTests.cs to verify:
- Build information is displayed when ShowBuildInformation is true
- Build information is hidden when ShowBuildInformation is false
- The build information content is correctly formatted
This is important since FooterTests.cs already has comprehensive tests for other Footer functionality.
linkdotnet
force-pushed
the
build-info
branch
from
93e2686 to
2220e98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.