Skip to content

fix(content): remove duplicate entries from community-themes.json - #34022

Closed
ityashag wants to merge 1 commit into
lingdojo:mainfrom
ityashag:fix/dedupe-community-themes
Closed

ityashag wants to merge 1 commit into
lingdojo:mainfrom
ityashag:fix/dedupe-community-themes

Conversation

@ityashag

Copy link
Copy Markdown
Contributor

community-themes.json lists some themes more than once: bamboo-shadow three times, and koi-glow, matcha-drift and sundown-shrine twice each. Every copy is identical to the theme's first entry, so this removes the five extra copies and keeps the first one of each. No theme changes or disappears.

It also keeps the file further from the 100 entries at which the Thanos content workflow drops the oldest half, since duplicates count toward that limit.

Checks

  • The file parses as JSON: 81 entries before, 76 after, and no repeated id.
  • The result is exactly the first entry for each id, in the original order.
  • The diff only removes lines (30 deletions, 5 entries of 6 lines).

bamboo-shadow was listed three times, and koi-glow, matcha-drift and
sundown-shrine twice each. Every copy matched its first entry, so this
keeps the first one and removes the other five.
@tentoumushii

Copy link
Copy Markdown
Collaborator

🎉 Thanks for your Pull Request, @ityashag!

We appreciate your contribution to KanaDojo!

Pre-merge checklist:

  • You starred our repo ⭐
  • Code follows project style guidelines
  • Changes have been tested locally
  • PR title is descriptive
  • If this closes an issue, it's linked with Closes #<number>

A maintainer will review your PR shortly. In the meantime, make sure all CI checks pass. You can run npm run check locally to match CI.

ありがとうございます! 🙏

@tentoumushii

Copy link
Copy Markdown
Collaborator

🤖 Auto-Review: ✅ Passed

This theme contribution has passed automated validation!

Checks passed:

  • ✅ Changed files are in the allowed location
  • ✅ Changed JSON files parse successfully
  • ✅ Related issue found

Once the quality check passes, this PR will be automatically approved for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants