Skip to content

fix: restore themes removed from community-themes.json - #33693

Open
ityashag wants to merge 1 commit into
lingdojo:mainfrom
ityashag:fix/restore-dropped-themes
Open

ityashag wants to merge 1 commit into
lingdojo:mainfrom
ityashag:fix/restore-dropped-themes

Conversation

@ityashag

@ityashag ityashag commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

📝 Description

Two merges removed five themes from community/content/community-themes.json. All five had already been merged:

Theme Added in Removed when
vaporwave-shrine #33680 #33668 merged
ninja-shadow #33685 #33668 merged
tsuyu-drizzle #33690 #33668 merged
origami-crane #33651 #33598 merged
kendo-strike #33668 #33598 merged

You can see this in the comparisons for #33668 and #33598.

This PR puts the five themes back with their original values and keeps ruby-kabuki. It takes the file from 74 to 79 themes, adding 30 lines and removing none.

🔗 Related Issue

Refs #33668 and #33598

There is no separate issue for this. The theme issues are already closed, even though their themes are currently missing from main.

✅ Pre-Submission Checklist

  • I have starred the repo ⭐
  • My code follows the project's code style and uses cn() utility where needed
  • I have run npm run check locally and there are no TypeScript/ESLint errors 🐞
  • My commit messages follow the Conventional Commits format
  • I have updated the documentation (if applicable) 📖
  • This PR is against the main branch

cn() and the documentation item don't apply, since this only restores JSON entries. I did not run npm run check; see the testing notes below. The second commit uses Git's default merge message.

🎯 Type of Change

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Documentation update (e.g., this file, README)
  • content: Content update (e.g., new kanji, vocab, or fonts in /static/)
  • style: UI/Theme changes (e.g., Tailwind, CSS, new themes)
  • refactor: Code refactor (no functional changes)
  • test: Test update (adding missing tests or correcting existing tests)
  • chore: Build, CI/CD, or dependency updates

🧪 How Has This Been Tested?

Test Steps:

  1. Parsed the file as JSON: it is valid and has 79 themes.
  2. Compared the restored entries with the versions from the commits above: the values are identical.
  3. Checked that every entry already on main is unchanged and that all theme IDs are unique.

Not tested: I did not run the KanaDojo app or npm run check.

📸 Screenshots/Videos (if applicable)

N/A: this restores existing entries.

📦 Additional Context

Other open theme PRs change this same file, so they could remove entries the same way. Checking the theme count when merging them would catch it.

@tentoumushii

Copy link
Copy Markdown
Collaborator

🎉 Thanks for your Pull Request, @ityashag!

We appreciate your contribution to KanaDojo!

Pre-merge checklist:

  • You starred our repo ⭐
  • Code follows project style guidelines
  • Changes have been tested locally
  • PR title is descriptive
  • If this closes an issue, it's linked with Closes #<number>

A maintainer will review your PR shortly. In the meantime, make sure all CI checks pass. You can run npm run check locally to match CI.

ありがとうございます! 🙏

@tentoumushii

Copy link
Copy Markdown
Collaborator

🤖 Auto-Review: ✅ Passed

This theme contribution has passed automated validation!

Checks passed:

  • ✅ Changed files are in the allowed location
  • ✅ Changed JSON files parse successfully
  • ✅ Related issue found

Once the quality check passes, this PR will be automatically approved for merge.

1 similar comment
@tentoumushii

Copy link
Copy Markdown
Collaborator

🤖 Auto-Review: ✅ Passed

This theme contribution has passed automated validation!

Checks passed:

  • ✅ Changed files are in the allowed location
  • ✅ Changed JSON files parse successfully
  • ✅ Related issue found

Once the quality check passes, this PR will be automatically approved for merge.

@ityashag ityashag changed the title fix: restore three themes removed from community-themes.json fix: restore themes removed from community-themes.json Nov 6, 2026
@ityashag

ityashag commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@tentoumushii heads up: theme PRs merged today are removing each other's entries from community-themes.json. #33668 removed three themes and #33598 removed two more, so main has 74 themes instead of 79. Both merges came right after a "Merge branch 'main' into…" commit. This PR restores all five. Merging it before other theme PRs, or checking the theme count when resolving conflicts, should stop it recurring.

@ityashag

Copy link
Copy Markdown
Contributor Author

@tentoumushii friendly follow-up: the five themes this PR restores (origami-crane, vaporwave-shrine, ninja-shadow, tsuyu-drizzle, kendo-strike) are still missing from community-themes.json on main. The PR still merges cleanly, and the only red check is Vercel's "Authorization required to deploy", which is the fork preview gate, not a build failure. Happy to rebase or split it into one PR per theme if that's easier to review.

Theme PRs merged on 2026-11-06 dropped origami-crane, vaporwave-shrine,
ninja-shadow, tsuyu-drizzle and kendo-strike from the file. This adds them
back after neon-sakura, where they were.
@ityashag
ityashag force-pushed the fix/restore-dropped-themes branch from 32fae1d to 248a8d5 Compare November 13, 2026 05:30
@tentoumushii

Copy link
Copy Markdown
Collaborator

🤖 Auto-Review: ✅ Passed

This theme contribution has passed automated validation!

Checks passed:

  • ✅ Changed files are in the allowed location
  • ✅ Changed JSON files parse successfully
  • ✅ Related issue found

Once the quality check passes, this PR will be automatically approved for merge.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants