Repository navigation
Conversation
🎉 Thanks for your Pull Request, @ityashag!We appreciate your contribution to KanaDojo! Pre-merge checklist:
A maintainer will review your PR shortly. In the meantime, make sure all CI checks pass. You can run ありがとうございます! 🙏 |
🤖 Auto-Review: ✅ PassedThis theme contribution has passed automated validation! Checks passed:
Once the quality check passes, this PR will be automatically approved for merge. |
1 similar comment
🤖 Auto-Review: ✅ PassedThis theme contribution has passed automated validation! Checks passed:
Once the quality check passes, this PR will be automatically approved for merge. |
|
@tentoumushii heads up: theme PRs merged today are removing each other's entries from |
|
@tentoumushii friendly follow-up: the five themes this PR restores (origami-crane, vaporwave-shrine, ninja-shadow, tsuyu-drizzle, kendo-strike) are still missing from |
Theme PRs merged on 2026-11-06 dropped origami-crane, vaporwave-shrine, ninja-shadow, tsuyu-drizzle and kendo-strike from the file. This adds them back after neon-sakura, where they were.
32fae1d to
248a8d5
Compare
🤖 Auto-Review: ✅ PassedThis theme contribution has passed automated validation! Checks passed:
Once the quality check passes, this PR will be automatically approved for merge. |
📝 Description
Two merges removed five themes from
community/content/community-themes.json. All five had already been merged:vaporwave-shrineninja-shadowtsuyu-drizzleorigami-cranekendo-strikeYou can see this in the comparisons for #33668 and #33598.
This PR puts the five themes back with their original values and keeps
ruby-kabuki. It takes the file from 74 to 79 themes, adding 30 lines and removing none.🔗 Related Issue
Refs #33668 and #33598
There is no separate issue for this. The theme issues are already closed, even though their themes are currently missing from
main.✅ Pre-Submission Checklist
cn()utility where needednpm run checklocally and there are no TypeScript/ESLint errors 🐞mainbranchcn()and the documentation item don't apply, since this only restores JSON entries. I did not runnpm run check; see the testing notes below. The second commit uses Git's default merge message.🎯 Type of Change
fix: Bug fix (non-breaking change which fixes an issue)feat: New feature (non-breaking change which adds functionality)docs: Documentation update (e.g., this file, README)content: Content update (e.g., new kanji, vocab, or fonts in/static/)style: UI/Theme changes (e.g., Tailwind, CSS, new themes)refactor: Code refactor (no functional changes)test: Test update (adding missing tests or correcting existing tests)chore: Build, CI/CD, or dependency updates🧪 How Has This Been Tested?
Test Steps:
mainis unchanged and that all theme IDs are unique.Not tested: I did not run the KanaDojo app or
npm run check.📸 Screenshots/Videos (if applicable)
N/A: this restores existing entries.
📦 Additional Context
Other open theme PRs change this same file, so they could remove entries the same way. Checking the theme count when merging them would catch it.