Repository navigation
content: add new japanese proverb - #31350
Merged
tentoumushii merged 1 commit intoSep 30, 2026
Merged
tentoumushii merged 1 commit into
tentoumushii merged 1 commit into
Conversation
Collaborator
🎉 Thanks for your Pull Request, @Pushpak731!We appreciate your contribution to KanaDojo! Pre-merge checklist:
A maintainer will review your PR shortly. In the meantime, make sure all CI checks pass. You can run ありがとうございます! 🙏 🎴🗻 Welcome to KanaDojo! This appears to be your first contribution—that's awesome! We're thrilled to have you here. If you have any questions, don't hesitate to ask. 🏯 |
Collaborator
🤖 Auto-Review: ✅ PassedThis proverb contribution has passed automated validation! Checks passed:
📎 Linked issue: #31339 Once the quality check passes, this PR will be automatically approved for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31339
📝 Description
Adds the Japanese proverb 腹八分目 (Hara hachibunme — "Stomach 80 percent full", meaning: "Eat in moderation") to
community/content/japanese-proverbs.json, appended as the last entry exactly as specified in the issue, matching the file's existing formatting (2-space indent, CRLF).🔗 Related Issue
Closes #31339
✅ Pre-Submission Checklist
cn()utility where needed (N/A — JSON content change only)npm run checklocally and there are no TypeScript/ESLint errors 🐞 (N/A — data-file-only change; file validated as strict, parseable JSON instead)mainbranch🎯 Type of Change
content: Content update🧪 How Has This Been Tested?
Test Steps:
japanese-proverbs.json(no duplicates introduced — checked against latestmain)unittest) covering:japanese/romaji/english/meaning; all values non-empty strings, no stray whitespace or control charactersjapanesecontains Japanese script only;romajiis ASCII with capitalization consistent with the file📸 Screenshots/Videos (if applicable)
N/A (data-file change)
📦 Additional Context
None