Skip to content

content: add new japanese proverb - #31350

Merged
tentoumushii merged 1 commit into
lingdojo:mainfrom
Pushpak731:content/add-japanese-proverb-hara-hachibunme
Sep 30, 2026
Merged

tentoumushii merged 1 commit into
lingdojo:mainfrom
Pushpak731:content/add-japanese-proverb-hara-hachibunme

Conversation

@Pushpak731

Copy link
Copy Markdown

Closes #31339

📝 Description

Adds the Japanese proverb 腹八分目 (Hara hachibunme — "Stomach 80 percent full", meaning: "Eat in moderation") to community/content/japanese-proverbs.json, appended as the last entry exactly as specified in the issue, matching the file's existing formatting (2-space indent, CRLF).

🔗 Related Issue

Closes #31339

✅ Pre-Submission Checklist

  • I have starred the repo ⭐
  • My code follows the project's code style and uses cn() utility where needed (N/A — JSON content change only)
  • I have run npm run check locally and there are no TypeScript/ESLint errors 🐞 (N/A — data-file-only change; file validated as strict, parseable JSON instead)
  • My commit messages follow the Conventional Commits format
  • I have updated the documentation (if applicable) 📖 (N/A)
  • This PR is against the main branch

🎯 Type of Change

  • content: Content update

🧪 How Has This Been Tested?

Test Steps:

  1. Verified the proverb does not already exist in japanese-proverbs.json (no duplicates introduced — checked against latest main)
  2. Ran an automated 29-case validation suite (Python unittest) covering:
    • File integrity — strict JSON parse, UTF-8 without BOM, CRLF endings preserved, ends with newline
    • Placement — exactly one new entry, appended last; all 87 pre-existing entries unchanged
    • Schema — all 88 entries have exactly the keys japanese / romaji / english / meaning; all values non-empty strings, no stray whitespace or control characters
    • Content — all four fields match the issue spec; key order matches file convention; japanese contains Japanese script only; romaji is ASCII with capitalization consistent with the file
    • Round-trip — lossless JSON serialize/parse
  3. Result: 29/29 tests pass ✅

📸 Screenshots/Videos (if applicable)

N/A (data-file change)

📦 Additional Context

None

Copilot AI balanced review requested due to automatic review settings September 30, 2026 17:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@tentoumushii

Copy link
Copy Markdown
Collaborator

🎉 Thanks for your Pull Request, @Pushpak731!

We appreciate your contribution to KanaDojo!

Pre-merge checklist:

  • You starred our repo ⭐
  • Code follows project style guidelines
  • Changes have been tested locally
  • PR title is descriptive
  • If this closes an issue, it's linked with Closes #<number>

A maintainer will review your PR shortly. In the meantime, make sure all CI checks pass. You can run npm run check locally to match CI.

ありがとうございます! 🙏


🎴🗻 Welcome to KanaDojo! This appears to be your first contribution—that's awesome! We're thrilled to have you here. If you have any questions, don't hesitate to ask. 🏯

@tentoumushii

Copy link
Copy Markdown
Collaborator

🤖 Auto-Review: ✅ Passed

This proverb contribution has passed automated validation!

Checks passed:

  • ✅ Changed files are in the allowed location
  • ✅ Changed JSON files parse successfully
  • ✅ Related issue found

📎 Linked issue: #31339

Once the quality check passes, this PR will be automatically approved for merge.

@tentoumushii
tentoumushii merged commit 2ece7a3 into lingdojo:main Sep 30, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[good first issue] 🎎 Add new Japanese Proverb 538 (good-first-issue)

3 participants