Skip to content

fix: repair invalid JSON in japanese-idioms.json (missing comma) - #29635

Merged
tentoumushii merged 1 commit into
lingdojo:mainfrom
Godsdar:fix/idioms-json-comma
Sep 2, 2026
Merged

tentoumushii merged 1 commit into
lingdojo:mainfrom
Godsdar:fix/idioms-json-comma

Conversation

@Godsdar

@Godsdar Godsdar commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

community/content/japanese-idioms.json is currently invalid JSON — a comma is missing between two adjacent entries (腰が重い and 頭が上がらない). This breaks parsing of the idioms content and would fail the check workflow.

Fix

Add the missing comma. Verified: the file now parses as valid JSON (28 entries).

  • Diff is +1 / -1 (only the comma) — no behavior change.
  • Content-only change: no TypeScript/UI impacted.

Notes

The two adjacent entries came in via a recent change (see #29460); this PR restores valid JSON so the content is parseable again.

@tentoumushii

Copy link
Copy Markdown
Collaborator

🎉 Thanks for your Pull Request, @Godsdar!

We appreciate your contribution to KanaDojo!

Pre-merge checklist:

  • You starred our repo ⭐
  • Code follows project style guidelines
  • Changes have been tested locally
  • PR title is descriptive
  • If this closes an issue, it's linked with Closes #<number>

A maintainer will review your PR shortly. In the meantime, make sure all CI checks pass. You can run npm run check locally to match CI.

ありがとうございます! 🙏

@Godsdar

Godsdar commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@lingdojo — bumping for review. Summary of checks on this PR:

  • check (lint/typecheck/test + content validation): green ✅
  • validate-and-merge: fails at actions/checkout of the fork PR head (repository: Godsdar/kana-dojo, ref 0fd5f433) — this is GitHub's restriction on checking out fork PR code in a pull_request_target-style workflow, not a content/CI issue. Same as the other fork PRs (feat(theme): add Wasanbon theme #29507, content: add japanese proverb 34 #29509).
  • welcome: green ✅
  • Vercel: needs repo authorization (repo-side).

The change is a one-line repair: community/content/japanese-idioms.json was invalid JSON (missing comma between 腰が重い and 頭が上がらない); it now parses (28 entries). +1/-1, no behavior change. Thanks for the great project!

@tentoumushii
tentoumushii merged commit 38670e9 into lingdojo:main Sep 2, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants